Add RISC-V platform support in discoapi#112
Conversation
Fixes #1 Add support for RISC-V 64-bit architecture in discoapi. * Add `riscv64` architecture to `ARCHITECTURE_MAP` in `src/main/java/io/foojay/api/distribution/Temurin.java`. * Update `getUrlForAvailablePkgs` method to include `riscv64` in `src/main/java/io/foojay/api/distribution/Temurin.java`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/gounthar/discoapi/issues/1?shareId=XXXX-XXXX-XXXX-XXXX).
|
The RiscV64 pkgs from Temurin are already available...please check for example this: https://api.foojay.io/disco/v3.0/packages?distribution=temurin&latest=available&release_status=ga&architecture=riscv64&jdk_version=23 |
|
Thank you for the feedback. I initially thought my proposed changes would resolve this SDKMan! issue. I now understand that adding I apologize for the confusion. I'm still learning how the system handles architectures without explicit definitions. Could you help me understand this better? |
|
SDKMan gets all OpenJDK and GraalVM distributions from discoapi. But that doesn’t mean they provide all architectures etc. that disco offers. |
Add riscv64 platform mapping across the disco-integration bridge: - Platform enum: add LINUX_RISCV64 - Release: map (linux, riscv64) -> LINUX_RISCV64 - Broker: map (linux, riscv64) -> linuxriscv64 - application.properties: add riscv64 entries for Temurin and Liberica Both vendors already publish riscv64 JDKs. The Disco API support (foojayio/discoapi#112) is pending; once deployed, these entries will activate automatically. Closes sdkman#45 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Closing this PR; as @HanSolo pointed out, the Disco API already serves riscv64 packages without needing an explicit mapping in the distribution classes. The actual missing piece is in Thanks for the explanation on how architecture resolution works! |
2 participants
Following issue sdkman/sdkman-cli#1321, I propose to add the
RISCV64architecture to discoapi.riscv64architecture toARCHITECTURE_MAPinsrc/main/java/io/foojay/api/distribution/Temurin.java.getUrlForAvailablePkgsmethod to includeriscv64insrc/main/java/io/foojay/api/distribution/Temurin.java.Summary
RISCV64architecture in the architecture mapping, enhancing the capability to handle a broader range of architectures for package requests.Walkthrough
The changes introduced in this pull request involve the addition of a new architecture,
RISCV64, to theARCHITECTURE_MAPwithin theTemurinclass. This update includes mapping theRISCV64architecture to the string representation "riscv64", allowing theTemurinclass to support RISC-V 64-bit architecture in URL parameters. No other modifications to logic or error handling were made, ensuring that the existing functionality of the class remains unchanged.Changes
RISCV64toARCHITECTURE_MAP, mapping to "riscv64".